[Devfile#1718 ] Adding renovate.json and test script to ensure sample can still be parsed and used by consumers#70
Merged
Conversation
Contributor
Author
|
I did make this PR, I am not sure variables such as ${{ env.MINIKUBE_VERSION }} or ${{ env.KUBERNETES_VERSION }} is declared |
michael-valdron
requested changes
Jul 14, 2025
michael-valdron
left a comment
michael-valdron
left a comment
Contributor
There was a problem hiding this comment.
@JslYoon Instead of trying to duplicate, I would suggest creating a new workflow that first pulls the devfile/registry repository, then runs the sample against each test suite. Also, good to create new check_*.sh scripts as the sample itself is the only input, the ones from devfile/registry look for multiple stacks under a stacks/ directory.
JslYoon
force-pushed
the
devfile#1718-renovate
branch
3 times, most recently
from
3629a8a to
0f2b1a2
Compare
michael-valdron
requested changes
Jul 16, 2025
JslYoon
force-pushed
the
devfile#1718-renovate
branch
2 times, most recently
from
0c0595f to
7d040d6
Compare
thepetk
reviewed
Jul 24, 2025
thepetk
left a comment
thepetk
left a comment
Contributor
There was a problem hiding this comment.
Just a small comment on the script usage
michael-valdron
requested changes
Jul 24, 2025
JslYoon
force-pushed
the
devfile#1718-renovate
branch
from
6180598 to
2772b8a
Compare
michael-valdron
requested changes
Jul 24, 2025
Signed-off-by: Lucas Yoon <lyoon@lyoon-thinkpadp1gen7.boston.csb>
JslYoon
force-pushed
the
devfile#1718-renovate
branch
from
2772b8a to
2fe8e1e
Compare
Signed-off-by: Lucas Yoon <lyoon@lyoon-thinkpadp1gen7.boston.csb>
JslYoon
force-pushed
the
devfile#1718-renovate
branch
from
eac1307 to
3ab30f3
Compare
michael-valdron
requested changes
Jul 25, 2025
michael-valdron
left a comment
michael-valdron
left a comment
Contributor
There was a problem hiding this comment.
@JslYoon Let's takeout the odo variable
Co-authored-by: Michael Valdron <michael.valdron@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Devfile#1718 ] Adding renovate.json and test script to ensure sample can still be parsed and used by consumers
devfile/api#1718
Adding renovate.json and test script to ensure sample can still be parsed and used by consumers.
tests include:
validate-devfile-schemas
check non terminating
python dependencies, lint, and pytests (if exists)